This repository was archived by the owner on Nov 10, 2025. It is now read-only.
Expose counter for getnativecontracts#900
Merged
vncoelho merged 2 commits intoneo-project:masterfrom May 3, 2024
Merged
Conversation
…ject#852 Reuse the same model and have updatecounter in the output. All the other fields were the same already, so old RpcClient can get results without any problems. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Now it's exactly the same server-side, so can be reused. Notice that UpdateCounter trick allows to parse responses from old servers (that are lacking "updatecounter" for this call), this simplifies upgrade, but can be removed in future versions. Signed-off-by: Roman Khimov <roman@nspcc.ru>
vncoelho
reviewed
May 2, 2024
Member
vncoelho
left a comment
There was a problem hiding this comment.
I will compile everything and test here today or tomorrow.
cschuchardt88
suggested changes
May 2, 2024
| @@ -1,47 +0,0 @@ | |||
| // Copyright (C) 2015-2024 The Neo Project. | |||
Member
There was a problem hiding this comment.
Please put this back. RpcClient needs it.
Jim8y
approved these changes
May 3, 2024
vncoelho
approved these changes
May 3, 2024
AnnaShaleva
reviewed
May 4, 2024
Member
AnnaShaleva
left a comment
There was a problem hiding this comment.
I'm too slow, but it's a really nice way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
neo-project/neo#2905 is incomplete without it.