This repository was archived by the owner on Nov 10, 2025. It is now read-only.
Merged
Conversation
Contributor
Author
AnnaShaleva
previously approved these changes
Mar 25, 2024
Contributor
Author
This was newly introduced in a merged pr, but i have no idea why it can pass the workflow. @AnnaShaleva please review again |
vncoelho
approved these changes
Mar 25, 2024
cschuchardt88
approved these changes
Mar 25, 2024
Member
|
testing here again |
Member
Its sample simple change; shouldn't affect anything but |
Member
|
Application log is fixed. Oracle still not #42 24.21 /opt/neo-modules/src/OracleService/OracleService.cs(260,65): error CS1503: Argument 3: cannot convert from 'byte[]' to 'Neo.Cryptography.ECC.ECCurve' [/opt/neo-modules/src/OracleService/OracleService.csproj] |
Member
|
Member
|
@shargon currently |
Member
I don't know, time ago neo-modules was not maintained by core devs... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr fix the rpc error