Skip to content
This repository was archived by the owner on Nov 10, 2025. It is now read-only.

fixed output of deps#849

Closed
cschuchardt88 wants to merge 5 commits intoneo-project:masterfrom
cschuchardt88:fix-deps
Closed

fixed output of deps#849
cschuchardt88 wants to merge 5 commits intoneo-project:masterfrom
cschuchardt88:fix-deps

Conversation

@cschuchardt88
Copy link
Member

@cschuchardt88 cschuchardt88 commented Nov 24, 2023 •
edited
Loading

The way this works.

  • dotnet build neo-modules.sln --configuration Release
  • outputs to $(ProjectDir)/bin/dist

Workflow example

    - name: Zip (TokensTracker)
      working-directory: ./src/TokensTracker/bin/dist
      run: Compress-Archive -Path * -Destination TokensTracker-v3.6.3.zip

image

@superboyiii

closes #848

superboyiii
superboyiii approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@superboyiii superboyiii left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works well for me.
It's the same behaviour as #846, so we need choice 1 @Liaojinghui @shargon

@superboyiii superboyiii mentioned this pull request Nov 27, 2023
Merged
@Jim8y
Copy link
Contributor

Jim8y commented Nov 27, 2023

It works well for me. It's the same behaviour as #846, so we need choice 1 @Liaojinghui @shargon

I pick the earlier one if they behave the same, unless with specific reasons. My principle is first come first get.

@cschuchardt88
Copy link
Member Author

cschuchardt88 commented Nov 28, 2023 •
edited
Loading

@superboyiii with #846 run this command dotnet build neo-modules.sln check output folder or use dotnet build neo-modules.sln --output ./dist you will get all the dlls.

@Jim8y
Copy link
Contributor

Jim8y commented Nov 28, 2023

@superboyiii with #846 run this command dotnet build neo-modules.sln check output folder or use dotnet build neo-modules.sln --output ./dist you will get all the dlls.

Just cheked the behavior, we dont need all of them in the same folder, but different dll in different corresponding plugin folder.

@cschuchardt88
Copy link
Member Author

cschuchardt88 commented Nov 28, 2023

nvm

@cschuchardt88 cschuchardt88 deleted the fix-deps branch November 28, 2023 02:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@superboyiii superboyiii superboyiii approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove unnecessary dll when build or publish a plugin

3 participants

@cschuchardt88 @Jim8y @superboyiii