Skip to content
This repository was archived by the owner on Nov 10, 2025. It is now read-only.

Added hardfork to RpcClient#825

Merged
shargon merged 3 commits intoneo-project:masterfrom
cschuchardt88:Hardfork-settings-rpcclient
Sep 26, 2023
Merged

Added hardfork to RpcClient#825
shargon merged 3 commits intoneo-project:masterfrom
cschuchardt88:Hardfork-settings-rpcclient

Conversation

@cschuchardt88
Copy link
Member

@cschuchardt88 cschuchardt88 commented Sep 15, 2023

Added hardfork to RpcClient and tested

This is for #823 implementation of hardfork settings in getversion rpc method.

"initialgasdistribution": 0,
"hardforks": [
{
"name": "HF_Aspidochelone",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, speaking of #822, can we avoid HF_ prefixes here? It's hardforks section already.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but it based off Enum Hardfork, So its parses the name, i guess i could put value, i believe that works.

Copy link
Member Author

@cschuchardt88 cschuchardt88 Sep 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh i see what your saying, Thats how its used in #823.

public enum Hardfork : byte
{
    HF_Aspidochelone,
    HF_Basilisk
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's not a client problem and not something client should be bothered with. It's just that I've only noticed it here. But server-side it'd probably be a bit better.

Copy link
Member Author

@cschuchardt88 cschuchardt88 Sep 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forkJson["name"] = hf.Key;

Code uses key of the enum which in our case is HF_Aspidochelone and HF_Basilisk. We would have to change the server to use the value instead. If you would like me to proceed in changing the server let me know.

Edit: I feel that you think the server didn't implement this. but it did, thats why im doing this. Yes i do think they merged it too fast #823.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's not a client problem and not something client should be bothered with. It's just that I've only noticed it here. But server-side it'd probably be a bit better.

Why we need it in server? We can remove it from both

Copy link
Member Author

@cschuchardt88 cschuchardt88 Sep 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remember this #823 someone merged it. To late in 3.6.1

@Jim8y
Copy link
Contributor

Jim8y commented Sep 26, 2023

Good to go? ifs its already in the server.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants