Skip to content
This repository was archived by the owner on Nov 10, 2025. It is now read-only.

Refac statedump#789

Closed
Ashuaidehao wants to merge 4 commits intoneo-project:masterfrom
Ashuaidehao:refac-statedump
Closed

Refac statedump#789
Ashuaidehao wants to merge 4 commits intoneo-project:masterfrom
Ashuaidehao:refac-statedump

Conversation

@Ashuaidehao
Copy link
Contributor

Close #736

string dirPathWithBlock = $"./Storage_{network:x8}/BlockStorage_{folder}";
Directory.CreateDirectory(dirPathWithBlock);
return dirPathWithBlock;
uint folder = (blockIndex / storagePerFolder) * storagePerFolder;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the naming scheme and will break scripts like https://github.com/nspcc-dev/neo-go/blob/master/scripts/compare-dumps/compare-dumps.go. Please keep the old scheme, I doubt changing it is important wrt to this PR goals.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll make a new simple plugin so you won't change it.

@Ashuaidehao Ashuaidehao mentioned this pull request Jan 19, 2023
/// <summary>
/// Height to begin real-time syncing and dumping on, consequently, dumping every block into a single files
/// </summary>
public int HeightToStartRealTimeSyncing { get; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove this configuration?
This can be useful when debugging or following the chain on real-time

@Ashuaidehao
Copy link
Contributor Author

Replaced by #790

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Data missing for random blocks in StatesDumper

3 participants