This repository was archived by the owner on Nov 10, 2025. It is now read-only.
RpcServer should support missing params request property#769
Merged
shargon merged 3 commits intoneo-project:masterfrom Oct 20, 2022
Merged
RpcServer should support missing params request property#769shargon merged 3 commits intoneo-project:masterfrom
shargon merged 3 commits intoneo-project:masterfrom
Conversation
Contributor
|
See also #747. |
Contributor
Author
shargon
approved these changes
Oct 5, 2022
Member
superboyiii
approved these changes
Oct 8, 2022
Member
|
Tested OK. |
Member
|
@erikzhang Could you have a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #768
Note, there are no tests for RpcServer currently. Should I add one for this functionality?