This repository was archived by the owner on Nov 10, 2025. It is now read-only.
Merged
Conversation
shargon
approved these changes
Oct 10, 2022
Jim8y
approved these changes
Oct 10, 2022
vncoelho
reviewed
Oct 17, 2022
| private async Task ProcessRequestAsync(DataCache snapshot, OracleRequest req) | ||
| { | ||
| Log($"Process oracle request txid: {req.OriginalTxid}, url: {req.Url}"); | ||
| Log($"[{req.OriginalTxid}] Process oracle request start:<{req.Url}>"); |
Member
There was a problem hiding this comment.
begin and end
start and finish
maybe begin is better
vncoelho
reviewed
Oct 17, 2022
|
|
||
| (OracleResponseCode code, string data) = await ProcessUrlAsync(req.Url); | ||
|
|
||
| Log($"[{req.OriginalTxid}] Process oracle request end:<{req.Url}>, responseCode:{code}, response:{data}"); |
vncoelho
reviewed
Oct 17, 2022
Member
vncoelho
left a comment
There was a problem hiding this comment.
I like the logs, I will soon test it on our examples.
superboyiii
approved these changes
Nov 2, 2022
Member
|
Tested OK. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.