Skip to content
This repository was archived by the owner on Nov 10, 2025. It is now read-only.

Add relayresult#200

Closed
bettybao1209 wants to merge 28 commits intoneo-project:masterfrom
bettybao1209:add-relayreason
Closed

Add relayresult#200
bettybao1209 wants to merge 28 commits intoneo-project:masterfrom
bettybao1209:add-relayreason

Conversation

@bettybao1209
Copy link
Copy Markdown
Contributor

@bettybao1209 bettybao1209 commented Mar 27, 2020

No description provided.

erikzhang
erikzhang suggested changes Mar 27, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@erikzhang erikzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#197 (comment)

erikzhang
erikzhang reviewed Mar 28, 2020
View reviewed changes
erikzhang
erikzhang reviewed Mar 30, 2020
View reviewed changes
erikzhang
erikzhang previously approved these changes Mar 30, 2020
View reviewed changes
chenquanyu
chenquanyu reviewed Mar 30, 2020
View reviewed changes
@erikzhang erikzhang dismissed their stale review March 30, 2020 08:59

There should be a dictionary.

chenquanyu
chenquanyu previously approved these changes Mar 30, 2020
View reviewed changes
@vncoelho
Copy link
Copy Markdown
Member

vncoelho commented Mar 30, 2020

close #205

@vncoelho vncoelho mentioned this pull request Mar 30, 2020
Closed
@vncoelho
Copy link
Copy Markdown
Member

vncoelho commented Mar 30, 2020

I am facing problem to test RpcServer because of the dependencies problem reported on #198, could you give a hand on that @bettybao1209 @superboyiii ?

shargon
shargon reviewed Mar 30, 2020
View reviewed changes
@nicolegys
Copy link
Copy Markdown
Contributor

nicolegys commented Mar 31, 2020

Test passed.

Test steps:

sendrawtransaction

  1. sendrawtransaction - tx not exsited
    result: return tx hash
    image
  2. sendrawtransaction - tx already exsited
    result: return error AlreadyExists
    image

submitblock
1.show state
image
2. submitblock - block not exsited
result: return block hash
image
3.show state
result: block height increased by 1
image
4. submitblock - block already exsited
result: return error AlreadyExists
image
5.show state
result: block height didn't change
image

vncoelho
vncoelho previously approved these changes Mar 31, 2020
View reviewed changes
@nicolegys nicolegys mentioned this pull request Apr 3, 2020
Merged
shargon
shargon reviewed Apr 7, 2020
View reviewed changes
@erikzhang erikzhang mentioned this pull request Apr 7, 2020
Closed
shargon
shargon previously approved these changes Apr 8, 2020
View reviewed changes
erikzhang
erikzhang reviewed Apr 8, 2020
View reviewed changes
@Qiao-Jin Qiao-Jin mentioned this pull request Apr 9, 2020
Merged
erikzhang
erikzhang reviewed Apr 9, 2020
View reviewed changes
@erikzhang
Copy link
Copy Markdown
Member

erikzhang commented Apr 9, 2020

Please wait for neo-project/neo#1548

@erikzhang
Copy link
Copy Markdown
Member

erikzhang commented Apr 10, 2020

neo-project/neo#1548 has been merged.

@bettybao1209
Copy link
Copy Markdown
Contributor Author

bettybao1209 commented Apr 10, 2020

neo-project/neo#1548 has been merged.

Ok, I open a new PR #220 and I'll close this one.

@bettybao1209 bettybao1209 deleted the add-relayreason branch April 13, 2020 02:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

4 more reviewers

@chenquanyu chenquanyu chenquanyu left review comments

@erikzhang erikzhang erikzhang left review comments

@shargon shargon shargon left review comments

@vncoelho vncoelho vncoelho left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bettybao1209 @vncoelho @nicolegys @erikzhang @shargon @chenquanyu