Skip to content
This repository was archived by the owner on Nov 10, 2025. It is now read-only.
This repository was archived by the owner on Nov 10, 2025. It is now read-only.

validateaddress should not accept hexs, or should it? #352

@roman-khimov

Description

@roman-khimov

Describe the bug
#309 changed some RPC APIs to accept Uint160 parameters as either base58-based address or 20-byte hex string. While in general this is a good thing (making APIs more useful for clients), one API stands out a little and that is validateaddress. In my understanding of it, it was specifically designed to check base58-encoded address for correctness (I'm not sure it's very useful, but that's what it does), so for it any non-base58 form of Uint160 is an invalid input and it shouldn't accept it.

Expected behavior
Revert the change for validateaddress and return its historic behavior.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions