use abstract method to define static oracle callback#998
Closed
Jim8y wants to merge 3 commits intoneo-project:masterfrom
Jim8y:static-IOracle
Closed
use abstract method to define static oracle callback#998Jim8y wants to merge 3 commits intoneo-project:masterfrom Jim8y:static-IOracle
Jim8y wants to merge 3 commits intoneo-project:masterfrom
Jim8y:static-IOracle
Conversation
cschuchardt88
approved these changes
Mar 19, 2024
cschuchardt88
approved these changes
Mar 19, 2024
Member
|
But why we want to use static interface in oracle, and not in others? we should use the same way |
Member
There was a problem hiding this comment.
I thought we were using block namespace scoping?
Contributor
Author
|
@shargon i am sorry to say this but i think it is a mess at all cause static or non-static all works as interface..... People can use it as static or non-static... how do we make an interace that both works for static and non-static @cschuchardt88 |
Member
We should try to focus on instance |
Contributor
Author
|
Use instance interface instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr updates the IOracle to define the oracle callback interface as static #993 (comment)