[Compiler fix pattern]pattern#985
Closed
Jim8y wants to merge 2 commits intoneo-project:masterfrom
Jim8y:pattern
Closed
[Compiler fix pattern]pattern#985Jim8y wants to merge 2 commits intoneo-project:masterfrom Jim8y:pattern
Jim8y wants to merge 2 commits intoneo-project:masterfrom
Jim8y:pattern
Conversation
shargon
reviewed
Mar 6, 2024
| foreach (var value in byteString) | ||
| { | ||
| if (!((value >= 65 && value <= 90) || (value >= 97 && value <= 122))) | ||
| if (value is (< 65 or > 90) and (< 97 or > 122)) |
Contributor
Author
There was a problem hiding this comment.
This is for showing you where is the problem.
Member
There was a problem hiding this comment.
But we should add unit test to ensure that is fixed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.