Proposal for scoped witness#969
Closed
igormcoelho wants to merge 2 commits intoneo-project:masterfrom
Closed
Conversation
Contributor
Author
|
@shargon this is just the idea to solve the problem. This way, problem is solved already, just need to adjust the tests. |
Member
|
Perfect, brother, I will check asap. Great job. |
Contributor
Author
|
Closing in favor of #968 ( I think I can adjust there). |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An implementation for #544
This is an alternative implementation to #928, but following a very different direction.
If this direction is not good enough, we close this @shargon @erikzhang
As long as it works, that's fine for me.