Skip to content

Disable compression by p2p#3655

Merged
shargon merged 11 commits intomasterfrom
disable-compression
Jan 16, 2025
Merged

Disable compression by p2p#3655
shargon merged 11 commits intomasterfrom
disable-compression

Conversation

@shargon
Copy link
Member

@shargon shargon commented Jan 8, 2025

Description

Step 1 of #2626, add node capability for disable compression

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Manual

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

roman-khimov
roman-khimov reviewed Jan 8, 2025
View reviewed changes
Copy link
Contributor

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add a configuration to disable local compression immediately, this is backwards-compatible (and make it send the new attribute in the subsequent version).

@shargon shargon changed the title Disable compression - Step 1 Disable compression by p2p Jan 8, 2025
cschuchardt88
cschuchardt88 reviewed Jan 9, 2025
View reviewed changes
Copy link
Member

@cschuchardt88 cschuchardt88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your missing ProtocolSettings.

@shargon
Copy link
Member Author

shargon commented Jan 9, 2025

Your missing ProtocolSettings.

Where?

roman-khimov
roman-khimov approved these changes Jan 9, 2025
View reviewed changes
@cschuchardt88
Copy link
Member

cschuchardt88 commented Jan 11, 2025

Your missing ProtocolSettings.

Where?

It's a ProtocolSetting, no?

@shargon
Copy link
Member Author

shargon commented Jan 11, 2025

Your missing ProtocolSettings.

Where?

It's a ProtocolSetting, no?

It's already done, isn't it?

@cschuchardt88
Copy link
Member

cschuchardt88 commented Jan 11, 2025 •
edited
Loading

Your missing ProtocolSettings.

Where?

It's a ProtocolSetting, no?

It's already done, isn't it?

As far as I saw, its just in the Settings class for neo-cli. It must be in the ProtocolSettings class as well?

@roman-khimov
Copy link
Contributor

roman-khimov commented Jan 11, 2025

But why ProtocolSettings? Currently it's in ApplicationConfiguration/P2P and to me it's a perfect fit.

@cschuchardt88
Copy link
Member

cschuchardt88 commented Jan 11, 2025 •
edited
Loading

But why ProtocolSettings? Currently it's in ApplicationConfiguration/P2P and to me it's a perfect fit.

Wouldn't you like to know if the node is using compression. For example ProtocolSettings.Default.

Plus Its a protocol setting isn't it? makes sense to have it in both places.

@shargon
Copy link
Member Author

shargon commented Jan 11, 2025 •
edited
Loading

But why ProtocolSettings? Currently it's in ApplicationConfiguration/P2P and to me it's a perfect fit.

Wouldn't you like to know if the node is using compression. For example ProtocolSettings.Default.

Plus Its a protocol setting isn't it? makes sense to have it in both places.

Why we want to have it replicated in multiple places?

@cschuchardt88
Copy link
Member

cschuchardt88 commented Jan 11, 2025

But why ProtocolSettings? Currently it's in ApplicationConfiguration/P2P and to me it's a perfect fit.

Wouldn't you like to know if the node is using compression. For example ProtocolSettings.Default.
Plus Its a protocol setting isn't it? makes sense to have it in both places.

Why we want to have it replicated in multiple places?

I answered that already!

Wouldn't you like to know if the node is using compression. For example ProtocolSettings.Default.

@shargon shargon requested a review from Jim8y January 13, 2025 08:47
nan01ab
nan01ab approved these changes Jan 16, 2025
View reviewed changes
src/Neo/Network/P2P/Capabilities/DisableCompressionCapability.cs Outdated
@@ -0,0 +1,31 @@
// Copyright (C) 2015-2024 The Neo Project.
//
// UnknownCapability.cs file belongs to the neo project and is free
Copy link
Contributor

@nan01ab nan01ab Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// UnknownCapability.cs file belongs to the neo project and is free
// DisableCompressionCapability.cs file belongs to the neo project and is free

@shargon shargon merged commit adc9a4c into master Jan 16, 2025
@shargon shargon deleted the disable-compression branch January 16, 2025 13:23
@AnnaShaleva AnnaShaleva mentioned this pull request Jan 20, 2025
Closed
@Jim8y Jim8y mentioned this pull request Jan 24, 2025
Merged
14 tasks
@ixje ixje mentioned this pull request Jan 29, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roman-khimov roman-khimov roman-khimov approved these changes

@Jim8y Jim8y Awaiting requested review from Jim8y

+2 more reviewers

@cschuchardt88 cschuchardt88 cschuchardt88 left review comments

@nan01ab nan01ab nan01ab approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Ready to Merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shargon @cschuchardt88 @roman-khimov @nan01ab