[Fixed] Dotnet version for DevContainer#3620
Conversation
vncoelho
left a comment
There was a problem hiding this comment.
Good!
now global does not need to be modified locally.
Can you add the link to the list of images?
Then we can follow easily next update.
|
images and what link? |
|
lets revert back to dotnet 8 please, cant use dotnet 9 for now. |
|
That is unnecessary, a update coming out next month that fixes the issues. Unless we have a new release coming out this month. then no reason to revert it.
What can't you use? If the problem is Plus I warned you all and didn't listen to me. So now I'm not going back to |
vncoelho
left a comment
There was a problem hiding this comment.
I think that if there is a release coming as @cschuchardt88 mentioned you should revert to 8.0, otherwise, let's keep fixing this one.
Revert to dotnet 8 should be considered.
AnnaShaleva
left a comment
There was a problem hiding this comment.
You can also fix the issue, if you compile the neo.vm to dotnet standard then import it.
But are you sure that the neo core itself is not affected by this bug in dotnet 9? Because BigInteger arithmetic is widely used in the core (not only in VM).
Only thing that isnt working is |
AnnaShaleva
left a comment
There was a problem hiding this comment.
and in the neo.vm is the really the only the place this happens.
If it's true, then I'm not against of this PR.
But in general I'd expect the same dotnet version to be used within the whole stack. It's the way how we build software in nspcc-dev org, and it's a good practice, the whole stack has the same minimum required Go version, so I'd expect the same from the neo-project org. So if we take a decision to revert to dotnet 8, then every project should be reverted.
Looks like elliptical curve uses |
Description
The version of
dotnetwas wrong for thedevcontainer.Type of change
How Has This Been Tested?
Checklist: