[Core Plugin] PR 3414 part 4. thread safe snapshot#3606
Merged
shargon merged 2 commits intoneo-project:masterfrom Dec 1, 2024
Merged
[Core Plugin] PR 3414 part 4. thread safe snapshot#3606shargon merged 2 commits intoneo-project:masterfrom
shargon merged 2 commits intoneo-project:masterfrom
Conversation
Contributor
Author
|
This pr tries to be align with pr 3414, thus minor changes to the variable name that does not affect any functionality is applied to this pr as well. |
shargon
reviewed
Nov 30, 2024
Member
Why do we need a lock on read? Lock is only required on batch. |
cschuchardt88
approved these changes
Dec 1, 2024
shargon
approved these changes
Dec 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Credits goes to chris. This is 4th part of pr 3414, it focus on providing a thread safe snapshot.
Fixes # #3414
Type of change
Checklist: