[Fix] StackItem.GetHashCode for CompoundType#3549
Merged
shargon merged 19 commits intoneo-project:masterfrom Nov 6, 2024
Merged
[Fix] StackItem.GetHashCode for CompoundType#3549shargon merged 19 commits intoneo-project:masterfrom
Fix] StackItem.GetHashCode for CompoundType#3549shargon merged 19 commits intoneo-project:masterfrom
Conversation
shargon
reviewed
Oct 23, 2024
nan01ab
reviewed
Oct 24, 2024
nan01ab
reviewed
Nov 4, 2024
shargon
reviewed
Nov 4, 2024
shargon
reviewed
Nov 5, 2024
shargon
reviewed
Nov 5, 2024
…hardt88/neo into fix/compoundtype-hashcode
shargon
approved these changes
Nov 5, 2024
Jim8y
approved these changes
Nov 6, 2024
nan01ab
reviewed
Nov 14, 2024
| foreach (var item in SubItems) | ||
| { | ||
| // This isn't prefect and leaves somethings unsolved. | ||
| if (item is CompoundType cItem) |
Contributor
There was a problem hiding this comment.
There is such a cause here:
var map1 = new Map();
map1[1] = 2;
map1[3] = 4;
var map2 = new Map();
map2[3] = 4;
map2[1] = 2;
Assert.AreEqual(map1.GetHashCode(), map2.GetHashCode());
Assert.AreEqual failed.
Because VM.Map uses OrderedDictionary internally, but OrderedDictionary is not ordered.
it should be fixed or not ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Close #3544
Type of change
How Has This Been Tested?
Checklist: