Skip to content

[Neo CLI FIX] fix https://github.com/neo-project/neo/issues/3357#3358

Merged
NGDAdmin merged 2 commits intoneo-project:masterfrom
Jim8y:fix-3357
Jun 26, 2024
Merged

[Neo CLI FIX] fix https://github.com/neo-project/neo/issues/3357#3358
NGDAdmin merged 2 commits intoneo-project:masterfrom
Jim8y:fix-3357

Conversation

@Jim8y
Copy link
Contributor

@Jim8y Jim8y commented Jun 24, 2024 •
edited
Loading

Description

This pr fixes the issue of version explained in #3357

Fixes # #3357

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Jim8y Jim8y linked an issue Jun 24, 2024 that may be closed by this pull request
version error 1.0.0 #3357
Closed
cschuchardt88
cschuchardt88 suggested changes Jun 24, 2024
View reviewed changes
Copy link
Member

@cschuchardt88 cschuchardt88 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vncoelho
I removed it. We input version in github workflow actions. Reason for this is so version is synced and doesnt get mismatched. If you were here you would know what going on. Plus @Jim8y wants small PR and since there isnt a release coming out right this second. No need jump to undo something Im changing to get repo up to date. And you end up wasting my time try to undo everything every single time. You should review or check-in daily to know and see what going on.

@cschuchardt88
Copy link
Member

cschuchardt88 commented Jun 25, 2024

@vncoelho so your saying with 👎 you want to do everything manually? And keep all these issues with the repo? When it comes time to release.

@vncoelho
Copy link
Member

vncoelho commented Jun 25, 2024

@vncoelho so your saying with 👎 you want to do everything manually? And keep all these issues with the repo? When it comes time to release.

no

cschuchardt88
cschuchardt88 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@cschuchardt88 cschuchardt88 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shargon
Ill approve this, seeing nothing is wrong with this PR. But I don't think we should have it. PR #3308 resolves this issue for release but not local development; for maintainable.

@NGDAdmin NGDAdmin merged commit e281dcd into neo-project:master Jun 26, 2024
@Jim8y Jim8y deleted the fix-3357 branch July 19, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shargon shargon shargon approved these changes

@vncoelho vncoelho vncoelho approved these changes

+1 more reviewer

@cschuchardt88 cschuchardt88 cschuchardt88 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Ready to Merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

version error 1.0.0

5 participants

@Jim8y @cschuchardt88 @vncoelho @shargon @NGDAdmin