Skip to content

[Neo Plugin Optimization] Catch format exception#3341

Merged
NGDAdmin merged 2 commits intoneo-project:masterfrom
Jim8y:rpcserver-exception
Jun 18, 2024
Merged

[Neo Plugin Optimization] Catch format exception#3341
NGDAdmin merged 2 commits intoneo-project:masterfrom
Jim8y:rpcserver-exception

Conversation

@Jim8y
Copy link
Contributor

@Jim8y Jim8y commented Jun 16, 2024

Description

This pr fixes the problem that some of the format exceptions in the rpcserver are not properly catched and converted to rpcexception. Problem was found when i was adding unit tests for rpcserver in #3339

Fixes # TODOs in #3339

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@NGDAdmin NGDAdmin merged commit 379ce75 into neo-project:master Jun 18, 2024
@Jim8y Jim8y deleted the rpcserver-exception branch July 19, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants