[Neo VM Style] Add comments and document to reference counter#3331
Merged
NGDAdmin merged 7 commits intoneo-project:masterfrom Jun 26, 2024
Merged
[Neo VM Style] Add comments and document to reference counter#3331NGDAdmin merged 7 commits intoneo-project:masterfrom
NGDAdmin merged 7 commits intoneo-project:masterfrom
Conversation
Jim8y
commented
Jun 12, 2024
Jim8y
commented
Jun 12, 2024
Contributor
Author
should be fine, its just comments. |
shargon
approved these changes
Jun 13, 2024
vncoelho
reviewed
Jun 13, 2024
vncoelho
reviewed
Jun 13, 2024
| if (!item.ObjectReferences.TryGetValue(parent, out var pEntry)) | ||
| { | ||
| pEntry = new(parent); | ||
| pEntry = new StackItem.ObjectReferenceEntry(parent); |
Member
There was a problem hiding this comment.
Can you revert this change from here?
Contributor
Author
There was a problem hiding this comment.
Problems like this are very minor, not worth a pr to fix, but if we don't fix it, it will always be this unclear syntax.
Member
There was a problem hiding this comment.
Fix in another PR, it is better.
Let just comments here
Even the underscore could be moved to another PR.
vncoelho
reviewed
Jun 13, 2024
vncoelho
reviewed
Jun 13, 2024
vncoelho
reviewed
Jun 13, 2024
cschuchardt88
approved these changes
Jun 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Neo VM reference counter is a very important component, but it is very complex and is hard to understand. Making it actually UNMAINTAINABLE. Thus having this pr that adds detailed explaination and comments to all its related code.
Fixes # None
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: