Fixed version display in neo-cli#3307
Merged
NGDAdmin merged 8 commits intoneo-project:masterfrom Jun 18, 2024
Merged
Conversation
Jim8y
previously approved these changes
Jun 8, 2024
14 tasks
shargon
previously approved these changes
Jun 8, 2024
Contributor
|
To be fair, we still have hashes internally and they're still clearly visible in P2P: Not sure if it's intended. I'd make it to not contain hash in the version at all for tagged (release) builds. |
Jim8y
approved these changes
Jun 9, 2024
shargon
approved these changes
Jun 16, 2024
Member
|
Seems that ut fails |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Log
versionstring inneo-cliFrom
To
Type of change
How Has This Been Tested?
Locally
Checklist: