Skip to content

Fixed version display in neo-cli#3307

Merged
NGDAdmin merged 8 commits intoneo-project:masterfrom
cschuchardt88:fix/neo-cli-versions
Jun 18, 2024
Merged

Fixed version display in neo-cli#3307
NGDAdmin merged 8 commits intoneo-project:masterfrom
cschuchardt88:fix/neo-cli-versions

Conversation

@cschuchardt88
Copy link
Member

Change Log

  • Fixed display of version string in neo-cli

From

image

To

image

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Locally

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Jim8y
Jim8y previously approved these changes Jun 8, 2024
shargon
shargon previously approved these changes Jun 8, 2024
@roman-khimov
Copy link
Contributor

To be fair, we still have hashes internally and they're still clearly visible in P2P:

2024-06-09T08:12:54.963+0300        INFO        started protocol        {"addr": "45.78.52.160:54127", "userAgent": "/Neo:3.7.4+7f227a3026fadeb9723280e6f961b6f29b0f8a7a/", "startHeight": 5506847, "id": 234120166}

Not sure if it's intended. I'd make it to not contain hash in the version at all for tagged (release) builds.

@cschuchardt88 cschuchardt88 dismissed stale reviews from shargon and Jim8y via 7bbc087 June 9, 2024 09:10
@shargon
Copy link
Member

shargon commented Jun 16, 2024

Seems that ut fails

@NGDAdmin NGDAdmin merged commit 2ca8467 into neo-project:master Jun 18, 2024
@cschuchardt88 cschuchardt88 deleted the fix/neo-cli-versions branch June 24, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants