[Neo Core Style] define a class for the contractbasemethod#3291
Merged
shargon merged 2 commits intoneo-project:masterfrom Jun 5, 2024
Merged
[Neo Core Style] define a class for the contractbasemethod#3291shargon merged 2 commits intoneo-project:masterfrom
shargon merged 2 commits intoneo-project:masterfrom
Conversation
…d name string and int pcount everywhere.
shargon
reviewed
Jun 5, 2024
shargon
reviewed
Jun 5, 2024
shargon
approved these changes
Jun 5, 2024
vncoelho
approved these changes
Jun 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Define a class for the contractbasemethod, avoid directly using method name string and int pcount everywhere.
Currently we directly use the string name of internal contract methods and its corresponding pcount as interger value everywhere, this makes it hard to maintain the core and is not a good coing experience. Thus i collect them together into a contractbasemethod record and added comments to explain them in detail.
Fixes # (issue)
Type of change
How Has This Been Tested?
Run existing tests are they are.
Test Configuration:
Checklist: