[NEO CLI] Remove comments in Json file#3278
Merged
shargon merged 3 commits intoneo-project:masterfrom May 27, 2024
Merged
Conversation
Contributor
Author
shargon
approved these changes
May 27, 2024
Member
shargon
left a comment
There was a problem hiding this comment.
I said that when it was introduced, it was weird
vncoelho
approved these changes
May 27, 2024
Contributor
|
oh, this is much better! 😻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Comments is not a standard of Json, can cause problem if the config json file is used in other tools. Thus remove comments but add explaining readme file as suggested by @gsmachado in #3277 (comment)
Fixes # #3277
Type of change
How Has This Been Tested?
No cource code is changed.
Test Configuration:
Checklist: