Skip to content

[NEO CLI] Remove comments in Json file#3278

Merged
shargon merged 3 commits intoneo-project:masterfrom
Jim8y:json-readme
May 27, 2024
Merged

[NEO CLI] Remove comments in Json file#3278
shargon merged 3 commits intoneo-project:masterfrom
Jim8y:json-readme

Conversation

@Jim8y
Copy link
Contributor

@Jim8y Jim8y commented May 27, 2024

Description

Comments is not a standard of Json, can cause problem if the config json file is used in other tools. Thus remove comments but add explaining readme file as suggested by @gsmachado in #3277 (comment)

Fixes # #3277

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

No cource code is changed.

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Jim8y
Copy link
Contributor Author

Jim8y commented May 27, 2024

@gsmachado

@Jim8y Jim8y linked an issue May 27, 2024 that may be closed by this pull request
@Jim8y Jim8y requested a review from a team May 27, 2024 00:43
Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I said that when it was introduced, it was weird

@gsmachado
Copy link
Contributor

oh, this is much better! 😻

@shargon shargon merged commit 68005ba into neo-project:master May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove all comments from JSON files

4 participants