Skip to content

Native: remove deprecated NamedCurve enum#3273

Merged
NGDAdmin merged 2 commits intomasterfrom
remove-deprecated-namedcurve
May 27, 2024
Merged

Native: remove deprecated NamedCurve enum#3273
NGDAdmin merged 2 commits intomasterfrom
remove-deprecated-namedcurve

Conversation

@AnnaShaleva
Copy link
Member

Description

3.7.0 (and a batch of 3.7.*) is out, which means that users can see the "Obsolete" warning for NamedCurve enum and migrate to NamedCurveHash.

Close #3236. This change does not introduce state difference and does not require node resync, it's fully compatible with the existing networks.

Type of change

  • Refactoring

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

3.7.0 (and a batch of 3.7.*) is out, which means that users can see the
"Obsolete" warning for NamedCurve enum and migrate to NamedCurveHash.

Close #3236.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you wait for tests?

I can just proceed on next Monday or Tuesday.

Did try to call or create a condition related to VerifyWithECDsa ? Since it is/will be deprecated. Can it still be called without this PR?

The logic itself looks good.

@cschuchardt88
Copy link
Member

Did try to call or create a condition related to VerifyWithECDsa ? Since it is/will be deprecated. Can it still be called without this PR?

No, Its the same method as before with different parameters and defaults.

@NGDAdmin NGDAdmin merged commit 59bd092 into master May 27, 2024
@NGDAdmin NGDAdmin deleted the remove-deprecated-namedcurve branch May 27, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get rid of deprecated NamedCurve enum

8 participants