Skip to content

Temp Fix Annotations/Warnings#3196

Merged
shargon merged 1 commit intoneo-project:masterfrom
cschuchardt88:annotations-temp-remove
Apr 18, 2024
Merged

Temp Fix Annotations/Warnings#3196
shargon merged 1 commit intoneo-project:masterfrom
cschuchardt88:annotations-temp-remove

Conversation

@cschuchardt88
Copy link
Member

@cschuchardt88 cschuchardt88 commented Apr 17, 2024

Change Log

Temp workaround until someone has time to convert Neo.csproj to <Nullable>enable</Nullable>

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@cschuchardt88
Copy link
Member Author

@shargon @vncoelho @Jim8y
Review Please

@vncoelho
Copy link
Member

@cschuchardt88 looks good, I can soon check with attention.
I think until next Thursday would be better to me.

@shargon shargon merged commit 13905e1 into neo-project:master Apr 18, 2024
@shargon shargon deleted the annotations-temp-remove branch April 18, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Too much warnings on every PR "Unchanged files with check annotations (beta)"

4 participants