Skip to content

[VM ADD] add debug info#3191

Merged
shargon merged 4 commits intoneo-project:masterfrom
Jim8y:debug-vm
Apr 11, 2024
Merged

[VM ADD] add debug info#3191
shargon merged 4 commits intoneo-project:masterfrom
Jim8y:debug-vm

Conversation

@Jim8y
Copy link
Contributor

@Jim8y Jim8y commented Apr 9, 2024

Description

Since the new test engine in the devpack is using the default execution engine now, it is hard to debug the vm execution.
thus i add this code to print the execution opcodes.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

This does not change any existing UT.

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

shargon
shargon reviewed Apr 10, 2024
View reviewed changes
Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if it is only for debugging, it seems excessive to me, starting a node with debug will mean not being able to write to the console

@Jim8y
Copy link
Contributor Author

Jim8y commented Apr 10, 2024

Screenshot 2024-04-10 at 16 18 12

I need this, this pr addresses it for me. As long as you have another solution to it, i accept.

@Jim8y
Copy link
Contributor Author

Jim8y commented Apr 10, 2024 •
edited
Loading

I just need it to be debuggable, tracable, fixable. Otherwise the compiler is unmaintainable.

@Jim8y
Copy link
Contributor Author

Jim8y commented Apr 11, 2024

@shargon something is wrong with the ut, oom

@superboyiii
Copy link
Member

superboyiii commented Apr 11, 2024

cd547263ed91ac91e8aa965cd35fca0
I think nothing wrong with UT, all passed on the local. Something may incorrect on workflow environment?

shargon
shargon reviewed Apr 11, 2024
View reviewed changes
Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a command line for execute script with dump is better

@Jim8y
Copy link
Contributor Author

Jim8y commented Apr 11, 2024 •
edited
Loading

Man, I am debugging compiler via unit test, that won't work for me.

@shargon
Copy link
Member

shargon commented Apr 11, 2024

Man, I am debugging compiler via unit test, that won't work for me.

We need to find a different way, if you try to run a node with this pr, the node will be unusable, maybe add this in unit tests engine?

@shargon shargon merged commit 3a12f3d into neo-project:master Apr 11, 2024
@Jim8y Jim8y deleted the debug-vm branch April 11, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shargon shargon shargon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jim8y @superboyiii @shargon