Merged
Conversation
shargon
reviewed
Mar 29, 2024
Contributor
|
@chenzhitong can you also add the satck change to the comments? like pop two, push one? |
cschuchardt88
suggested changes
Mar 30, 2024
Member
cschuchardt88
left a comment
There was a problem hiding this comment.
You to change all method names to have a Prefix of Push or Pop or Add or Remove. So we can tell what's going on.
Contributor
There was a problem hiding this comment.
This pr only focus on adding comments to existing codes.
Member
There was a problem hiding this comment.
Add
CompareTomethod.
Focus on the changes in the pull request.
Contributor
Author
OK |
shargon
reviewed
Apr 1, 2024
shargon
reviewed
Apr 2, 2024
shargon
approved these changes
Apr 2, 2024
Member
Review not related to the PR. I will merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.