Skip to content

Repo Configuration Fixes#3183

Merged
shargon merged 10 commits intoneo-project:masterfrom
cschuchardt88:fix/repo
Mar 27, 2024
Merged

Repo Configuration Fixes#3183
shargon merged 10 commits intoneo-project:masterfrom
cschuchardt88:fix/repo

Conversation

@cschuchardt88
Copy link
Member

@cschuchardt88 cschuchardt88 commented Mar 26, 2024

Change Log

  • Fixed reporting with coverlet.msbuild
  • Updated dotnet version to 8.0.202 in global.json file
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Jim8y
Copy link
Contributor

Jim8y commented Mar 26, 2024

version must be specified?

Jim8y
Jim8y reviewed Mar 26, 2024
View reviewed changes
@cschuchardt88
Copy link
Member Author

cschuchardt88 commented Mar 26, 2024

Working Great Now
👍 🛩️ 💯 🥇 😃

@shargon @Jim8y @vncoelho

[coverlet] 
Calculating coverage result...
  [coverlet] MergeWith: '/home/runner/work/neo/neo/TestResults/coverage/coverage.net8.0.json'.
  Generating report '/home/runner/work/neo/neo/TestResults/coverage/coverage.net8.0.info'

+----------------------------+--------+--------+--------+
| Module                     | Line   | Branch | Method |
+----------------------------+--------+--------+--------+
| Neo.Json                   | 84.71% | 65.33% | 81.5%  |
+----------------------------+--------+--------+--------+
| Neo.VM                     | 87.65% | 80.6%  | 88.3%  |
+----------------------------+--------+--------+--------+
| Neo.Cryptography.BLS12_381 | 87.99% | 63%    | 73.96% |
+----------------------------+--------+--------+--------+
| Neo                        | 78.9%  | 65.38% | 81.61% |
+----------------------------+--------+--------+--------+
| Neo.Extensions             | 78.57% | 0%     | 80%    |
+----------------------------+--------+--------+--------+
| Neo.IO                     | 75.36% | 83.82% | 75%    |
+----------------------------+--------+--------+--------+
| Neo.ConsoleService         | 15.66% | 13.04% | 19.4%  |
+----------------------------+--------+--------+--------+
+---------+--------+--------+--------+
|         | Line   | Branch | Method |
+---------+--------+--------+--------+
| Total   | 79.22% | 65.6%  | 80.6%  |
+---------+--------+--------+--------+
| Average | 72.69% | 53.02% | 71.39% |
+---------+--------+--------+--------+

Jim8y
Jim8y previously approved these changes Mar 26, 2024
View reviewed changes
@Jim8y Jim8y requested a review from AnnaShaleva March 26, 2024 11:55
@cschuchardt88
Copy link
Member Author

cschuchardt88 commented Mar 26, 2024

@Jim8y Sorry I forgot one thing...

@cschuchardt88 cschuchardt88 requested a review from Jim8y March 26, 2024 11:59
shargon
shargon reviewed Mar 26, 2024
View reviewed changes
vncoelho
vncoelho reviewed Mar 26, 2024
View reviewed changes
Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fixes the coverage increase in 65822cf

That is why it decreases now

vncoelho
vncoelho reviewed Mar 26, 2024
View reviewed changes
Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can remove the -m:1

The main fix here was the problem introduced in the last but one PR that forced all formats to be lcov

@cschuchardt88 cschuchardt88 requested a review from vncoelho March 26, 2024 15:25
@shargon
Copy link
Member

shargon commented Mar 27, 2024

Lcov havent got the namespace information I think

AnnaShaleva
AnnaShaleva approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be legit.

@shargon shargon merged commit c550fc2 into neo-project:master Mar 27, 2024
@shargon shargon deleted the fix/repo branch March 27, 2024 07:49
@cschuchardt88 cschuchardt88 mentioned this pull request May 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shargon shargon shargon approved these changes

@vncoelho vncoelho vncoelho approved these changes

@AnnaShaleva AnnaShaleva AnnaShaleva approved these changes

@Jim8y Jim8y Awaiting requested review from Jim8y

Assignees

No one assigned

Labels

Waiting for Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cschuchardt88 @Jim8y @shargon @vncoelho @AnnaShaleva