Conversation
|
This is required now for query the manifest and nef for native contracts |
|
Has to be public? |
After this was public, the nef, and the manifest |
| namespace Neo.Persistence | ||
| { | ||
| internal class MemoryStoreProvider : IStoreProvider | ||
| public class MemoryStoreProvider : IStoreProvider |
There was a problem hiding this comment.
@Jim8y Now that we have two constructors in neoSystem, we need to expose also de provider, otherwise, devpack also fails.
What I am saying is why not make it visible to other sub modules, instead of making this one public. |
|
|
||
| <ItemGroup> | ||
| <InternalsVisibleTo Include="Neo.SmartContract.Testing" /> | ||
| <InternalsVisibleTo Include="Neo.SmartContract.TestEngine" /> |
There was a problem hiding this comment.
Now, the old testEngine require some internals too
|
Up to you to decide, but once you make them public, there is no way back, you can not change them at well anymore, and you must maintain them. |
These are good to be public |
Required for neo-project/neo-modules#881