Merged
Conversation
vncoelho
reviewed
Feb 20, 2024
| { | ||
| private static readonly ProtocolSettings protocol = ProtocolSettings.Load("config.json"); | ||
| private static readonly NeoSystem system = new(protocol, new MemoryStore()); | ||
| private static readonly NeoSystem system = new(protocol, (string)null); |
Member
There was a problem hiding this comment.
So, what will be the default store?
vncoelho
reviewed
Feb 20, 2024
Member
vncoelho
left a comment
There was a problem hiding this comment.
It is related to the PR that made MemoryStore the default one, right?
So, let's change the .config.json default to be MemoryStore, in this way we remove LevelDB dependency, keeping the idea behind the original change.
shargon
commented
Feb 20, 2024
| /// <param name="storageProvider">The storage engine used to create the <see cref="IStoreProvider"/> objects. If this parameter is <see langword="null"/>, a default in-memory storage engine will be used.</param> | ||
| /// <param name="storagePath">The path of the storage. If <paramref name="storageProvider"/> is the default in-memory storage engine, this parameter is ignored.</param> | ||
| public NeoSystem(ProtocolSettings settings, string? storageProvider = null, string? storagePath = null) : | ||
| this(settings, StoreFactory.GetStoreProvider(storageProvider ?? nameof(MemoryStore)), storagePath) |
Jim8y
approved these changes
Feb 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close neo-project/neo-modules#874 #3144