Skip to content

Decouple calculate fee from Wallet#3147

Merged
shargon merged 5 commits intomasterfrom
core-decouple-walletfee
Feb 23, 2024
Merged

Decouple calculate fee from Wallet#3147
shargon merged 5 commits intomasterfrom
core-decouple-walletfee

Conversation

@shargon
Copy link
Member

@shargon shargon commented Feb 18, 2024

Copy of #2354
Close #2352

@shargon
Copy link
Member Author

shargon commented Feb 19, 2024

@Jim8y merge?

@vncoelho
Copy link
Member

I did not remember that I created this issue...aheuaheuaea
Let me review

@shargon shargon merged commit d8af2c6 into master Feb 23, 2024
@shargon shargon deleted the core-decouple-walletfee branch February 23, 2024 00:44
@roman-khimov roman-khimov added this to the v3.7.0 milestone Feb 27, 2024
@dusmart
Copy link

dusmart commented May 10, 2024

It's an important public function maybe used by some plugins or elsewhere. The best practice is to keep that function and mark it obsolete instead of deleting it directly.

Although this has been merged, I have to reminder that NEO N3 is a sophisticated blockchain now and we'd better providing compatibility to others as much as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Question] Does CalculateNetworkFee(DataCache snapshot, Transaction tx) needs to be inside Wallet? Make network fee calculation more generic.

4 participants