[Neo-CLI ] update the null check#3126
Closed
Jim8y wants to merge 2 commits intoneo-project:masterfrom
Closed
Conversation
Contributor
Author
|
I did not change the code but the null check. The reason that I updated so many codes is because i changed their order, make wallet close to wallet, block close to block. If i do not make them together, i would have to open another pr to do it, a waste of your revewing efforts. |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Neo-CLI is nullable, however, the code still check if a non-null value is null or not, its not right.
And while doing this, I also reorganized the code to make it more clear for each section.
Fixes # (issue)
Type of change
How Has This Been Tested? Running existing code
Test Configuration:
Checklist: