Skip to content

[Neo Benchmark: Fix] fix the benchmark#3109

Merged
shargon merged 2 commits intoneo-project:masterfrom
Jim8y:fix-benchmark
Feb 2, 2024
Merged

[Neo Benchmark: Fix] fix the benchmark#3109
shargon merged 2 commits intoneo-project:masterfrom
Jim8y:fix-benchmark

Conversation

@Jim8y
Copy link
Contributor

@Jim8y Jim8y commented Jan 25, 2024

Description

Since we have updated the default value of the protocol setting, it actually breaks the existing benchmark. This pr trys to fix it.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Test Configuration:

Run the benchmark in the debug mode.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

cschuchardt88
cschuchardt88 reviewed Jan 25, 2024
View reviewed changes
@Jim8y
Copy link
Contributor Author

Jim8y commented Jan 26, 2024

@superboyiii :

Neo -> D:\a\neo\neo\src\Neo\bin\Debug\net7.0\Neo.dll
Neo.UnitTests -> D:\a\neo\neo\tests\Neo.UnitTests\bin\Debug\net7.0\Neo.UnitTests.dll
Test run for D:\a\neo\neo\tests\Neo.UnitTests\bin\Debug\net7.0\Neo.UnitTests.dll (.NETCoreApp,Version=v7.0)
Microsoft (R) Test Execution Command Line Tool Version 17.7.2 (x64)
Copyright (c) Microsoft Corporation. All rights reserved.

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
Failed TestCreateAccount [30 ms]
Error Message:
Assert.IsTrue failed.
Stack Trace:
at Neo.UnitTests.Wallets.NEP6.UT_NEP6Wallet.TestCreateAccount() in D:\a\neo\neo\tests\Neo.UnitTests\Wallets\NEP6\UT_NEP6Wallet.cs:line 94
at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)

Neo.CLI -> D:\a\neo\neo\src\Neo.CLI\bin\Debug\net7.0\neo-cli.dll
Neo.GUI -> D:\a\neo\neo\src\Neo.GUI\bin\Debug\net7.0-windows\Neo.GUI.dll

Failed! - Failed: 1, Passed: 686, Skipped: 0, Total: 687, Duration: 17 s - Neo.UnitTests.dll (net7.0)

this test error appears randomly. Can you please check?

@superboyiii
Copy link
Member

superboyiii commented Feb 1, 2024 •
edited
Loading

this test error appears randomly. Can you please check?

At leat this case always runs successfully on mine. But I notice if run all UT cases, some parameters will pollute other cases which could cause mismatching the expected result. But if run these failed cases independently, they will work well. Maybe it's better to fix these later.

run all:
1706770931253

re-run the failed:
image

@shargon shargon merged commit 2dd972d into neo-project:master Feb 2, 2024
@Jim8y Jim8y deleted the fix-benchmark branch February 2, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shargon shargon shargon approved these changes

+1 more reviewer

@cschuchardt88 cschuchardt88 cschuchardt88 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Jim8y @superboyiii @shargon @cschuchardt88