Add: enable command line command by Jim8y · Pull Request #3040 · neo-project/neo

Jim8y · 2023-12-29T09:53:30Z

This pr add commandline commands to neo-cli:

commands:

new Option<string>(new[] { "-c", "--config","/config" }, "Specifies the config file."),
new Option<string>(new[] { "-w", "--wallet","/wallet" }, "The path of the neo3 wallet [*.json]."),
new Option<string>(new[] { "-p", "--password" ,"/password" }, "Password to decrypt the wallet, either from the command line or config file."),
new Option<string>(new[] { "--db-engine","/db-engine" }, "Specify the db engine."),
new Option<string>(new[] { "--db-path","/db-path" }, "Specify the db path."),
new Option<string>(new[] { "--noverify","/noverify" }, "Indicates whether the blocks need to be verified when importing."),
new Option<string[]>(new[] { "--plugins","/plugins" }, "The names of the plugins [plugin1 plugin2]."),

cschuchardt88 · 2023-12-29T18:25:59Z

This is starting to turn into neo-express? What is the point of this?

Jim8y · 2023-12-30T04:23:04Z

This is starting to turn into neo-express? What is the point of this?

Does it hurt?

src/Neo.CLI/Settings.cs

src/Neo.CLI/CLI/MainService.CommandLine.cs

* master: Fixed asp.net core project (neo-project#3067) Updated BLS12_381 (neo-project#3074) avoid nonsense exception messages. (neo-project#3063) Removed `MyGet` (neo-project#3071) Updated unit-test (neo-project#3073) add hash verification for OnImport (neo-project#3070) Make public ReadUserInput (neo-project#3068) Removed asp.net core (neo-project#3065) Enforce Line Endings in `.editorconfig` (neo-project#3060) Remove some warnings (neo-project#3057) Fixed workflow timeout-minutes (neo-project#3048) Fix: specify the error message (neo-project#3030) Removes `WebSocket`s from the network layer (neo-project#3039) set timeout for tests (neo-project#3046) Fix: Editconfig (neo-project#3023) Set project as nullable (neo-project#3042) Fix: fix equal (neo-project#3028) # Conflicts: # src/Neo.CLI/CLI/MainService.cs # src/Neo.CLI/Settings.cs # src/Neo/ProtocolSettings.cs

shargon

Why src/Neo.CLI/CLI/CommandLineOption.cs warnings if it was not changed and we already merge some commits without this problem

shargon

Any way to use /help with this package?

src/Neo.CLI/Settings.cs

shargon · 2024-01-11T12:30:11Z

@Jim8y Conflicting files :S

* master: Adding NNS to `neo-cli` (neo-project#3032) # Conflicts: # src/Neo.CLI/Settings.cs

This reverts commit 7d54c5d.

shargon · 2024-01-11T13:08:40Z

You don't want to move the config files?

src/Neo.CLI/CLI/MainService.cs

vncoelho

/workspaces/neo/src/Neo.CLI/Settings.cs(65,16): warning CS8618: Non-nullable property 'Contracts' must contain a non-null value when exiting constructor. Consider declaring the property as nullable. [/workspaces/neo/src/Neo.CLI/Neo.CLI.csproj::TargetFramework=net7.0]
/workspaces/neo/src/Neo.CLI/CLI/MainService.CommandLine.cs(79,21): error CS0200: Property or indexer 'StorageSettings.Engine' cannot be assigned to -- it is read only [/workspaces/neo/src/Neo.CLI/Neo.CLI.csproj::TargetFramework=net7.0]
/workspaces/neo/src/Neo.CLI/CLI/MainService.CommandLine.cs(80,21): error CS0200: Property or indexer 'StorageSettings.Path' cannot be assigned to -- it is read only [/workspaces/neo/src/Neo.CLI/Neo.CLI.csproj::TargetFramework=net7.0]

Build FAILED.

/workspaces/neo/src/Neo.CLI/Settings.cs(65,16): warning CS8618: Non-nullable property 'Contracts' must contain a non-null value when exiting constructor. Consider declaring the property as nullable. [/workspaces/neo/src/Neo.CLI/Neo.CLI.csproj::TargetFramework=net7.0]
/workspaces/neo/src/Neo.CLI/CLI/MainService.CommandLine.cs(79,21): error CS0200: Property or indexer 'StorageSettings.Engine' cannot be assigned to -- it is read only [/workspaces/neo/src/Neo.CLI/Neo.CLI.csproj::TargetFramework=net7.0]
/workspaces/neo/src/Neo.CLI/CLI/MainService.CommandLine.cs(80,21): error CS0200: Property or indexer 'StorageSettings.Path' cannot be assigned to -- it is read only [/workspaces/neo/src/Neo.CLI/Neo.CLI.csproj::TargetFramework=net7.0]
    1 Warning(s)
    2 Error(s)

I think that I destroyed something when merged and conflicts resolved

Jim8y · 2024-01-12T17:36:52Z

I dont know, my local test passes.

src/Neo.CLI/Settings.cs

src/Neo.CLI/CLI/MainService.cs

Co-authored-by: Shargon <shargon@gmail.com>

cschuchardt88 · 2024-02-11T06:31:50Z

You have changed the interface. In doing so, i have found a bug. As you can see from the images below. That the CLI prompt is still open. When people try to run a command like show state it will clear the screen and render nothing. Please revert!!!

Run `.\neo-cli.exe /noverify`

when you type in `show state`

@shargon why did you merge this? You need two approvals. I only see one.

cschuchardt88 · 2024-02-11T06:35:51Z

src/Neo.CLI/CLI/MainService.cs

-            for (int i = 0; i < args.Length; i++)
-                switch (args[i])
-                {
-                    case "/noverify":


This needs to be added back somehow.

shargon · 2024-02-11T09:42:39Z

You have changed the interface. In doing so, i have found a bug. As you can see from the images below. That the CLI prompt is still open. When people try to run a command like show state it will clear the screen and render nothing. Please revert!!!

Run .\neo-cli.exe /noverify

when you type in show state

@shargon why did you merge this? You need two approvals. I only see one.

We can add in the readme the backwards incompatible changes, but we can't preserve all the previous version if we try to improve the new one, when it's released it could come with this information. With this change, the cli is much better, and people only need to change /verify to --xxx

shargon · 2024-02-11T09:44:05Z

@shargon why did you merge this? You need two approvals. I only see one.

Is not my pr, so technically is @Jim8y and me, is two.

cschuchardt88 · 2024-02-11T10:24:23Z

You have changed the interface. In doing so, i have found a bug. As you can see from the images below. That the CLI prompt is still open. When people try to run a command like show state it will clear the screen and render nothing. Please revert!!!

Run .\neo-cli.exe /noverify

when you type in show state

@shargon why did you merge this? You need two approvals. I only see one.

We can add in the readme the backwards incompatible changes, but we can't preserve all the previous version if we try to improve the new one, when it's released it could come with this information. With this change, the cli is much better, and people only need to change /verify to --xxx

that is fine.

Can you fix the bug with the cli prompt bugging out on invalid arguments on command-line? cli command show state doesn't work anymore when that happens.

shargon · 2024-02-11T10:56:52Z

You have changed the interface. In doing so, i have found a bug. As you can see from the images below. That the CLI prompt is still open. When people try to run a command like show state it will clear the screen and render nothing. Please revert!!!

Run .\neo-cli.exe /noverify

when you type in show state

@shargon why did you merge this? You need two approvals. I only see one.

We can add in the readme the backwards incompatible changes, but we can't preserve all the previous version if we try to improve the new one, when it's released it could come with this information. With this change, the cli is much better, and people only need to change /verify to --xxx

that is fine.

Can you fix the bug with the cli prompt bugging out on invalid arguments on command-line? cli command show state doesn't work anymore when that happens.

We found a bug, we fix the bug, we can open a new pr to fix it, please open a issue, remember that this version is not released yet.

Jim8y added 2 commits December 29, 2023 17:52

enable command line command

f93ce8f

fix GUI

86137ae

shargon reviewed Dec 30, 2023

View reviewed changes

src/Neo.CLI/Settings.cs Show resolved Hide resolved

Merge branch 'master' into commandline

12ef4fc

shargon reviewed Jan 10, 2024

View reviewed changes

src/Neo.CLI/CLI/MainService.CommandLine.cs Outdated Show resolved Hide resolved

shargon reviewed Jan 10, 2024

View reviewed changes

Jim8y and others added 8 commits January 10, 2024 19:12

update format

cef330e

Merge branch 'master' into commandline

78d584e

remove network config

502b154

Merge branch 'master' into commandline

baa17a1

Fix conflicts

a90b401

Remove Settings messages

9b06a1b

My review

af5dc0e

Add NoVerify check in IsValid

b0f9a22

shargon previously approved these changes Jan 11, 2024

View reviewed changes

src/Neo.CLI/Settings.cs Show resolved Hide resolved

Clean using

392ba58

shargon dismissed their stale review via 392ba58 January 11, 2024 07:33

Jim8y added 5 commits January 11, 2024 21:00

Merge branch 'master' into commandline

b558c50

* master: Adding NNS to `neo-cli` (neo-project#3032) # Conflicts: # src/Neo.CLI/Settings.cs

format

f6471cf

move config

7d54c5d

Revert "move config"

a4c760d

This reverts commit 7d54c5d.

fix config

3909261

shargon reviewed Jan 11, 2024

View reviewed changes

src/Neo.CLI/CLI/MainService.cs Outdated Show resolved Hide resolved

Jim8y added 2 commits January 11, 2024 21:24

update plugins install command

b530d50

format

d2333e9

shargon previously approved these changes Jan 11, 2024

View reviewed changes

Merge branch 'master' into commandline

e9fc4d8

vncoelho dismissed shargon’s stale review via e9fc4d8 January 12, 2024 17:19

vncoelho reviewed Jan 12, 2024

View reviewed changes

Jim8y and others added 2 commits January 13, 2024 01:39

fix build error

c253012

Merge branch 'master' into commandline

6f6afd1

shargon reviewed Jan 22, 2024

View reviewed changes

src/Neo.CLI/Settings.cs Show resolved Hide resolved

src/Neo.CLI/CLI/MainService.cs Outdated Show resolved Hide resolved

vncoelho and others added 3 commits January 30, 2024 11:28

Merge branch 'master' into commandline

6a7c7e6

Update src/Neo.CLI/CLI/MainService.cs

ec924a2

Co-authored-by: Shargon <shargon@gmail.com>

Fix Contracts

1f3f7d6

shargon approved these changes Feb 1, 2024

View reviewed changes

shargon merged commit 569b614 into neo-project:master Feb 1, 2024

cschuchardt88 reviewed Feb 11, 2024

View reviewed changes

roman-khimov added this to the v3.7.0 milestone Feb 27, 2024

chenzhitong mentioned this pull request Apr 3, 2024

Documentation updates for version 3.7 neo-project/neo-dev-portal#99

Closed

12 tasks

Conversation

Jim8y commented Dec 29, 2023 • edited by shargon Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cschuchardt88 commented Dec 29, 2023

Uh oh!

Jim8y commented Dec 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shargon left a comment

Choose a reason for hiding this comment

Uh oh!

shargon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shargon commented Jan 11, 2024

Uh oh!

shargon commented Jan 11, 2024

Uh oh!

Uh oh!

vncoelho left a comment

Choose a reason for hiding this comment

Uh oh!

Jim8y commented Jan 12, 2024

Uh oh!

Uh oh!

Uh oh!

cschuchardt88 commented Feb 11, 2024

Run .\neo-cli.exe /noverify

when you type in show state

Uh oh!

cschuchardt88 Feb 11, 2024

Choose a reason for hiding this comment

Uh oh!

shargon commented Feb 11, 2024

Run .\neo-cli.exe /noverify

when you type in show state

Uh oh!

shargon commented Feb 11, 2024

Uh oh!

cschuchardt88 commented Feb 11, 2024

Run .\neo-cli.exe /noverify

when you type in show state

Uh oh!

shargon commented Feb 11, 2024

Run .\neo-cli.exe /noverify

when you type in show state

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Jim8y commented Dec 29, 2023 •

edited by shargon

Loading

Jim8y commented Dec 30, 2023 •

edited

Loading

Run `.\neo-cli.exe /noverify`

when you type in `show state`

Run `.\neo-cli.exe /noverify`

when you type in `show state`

Run `.\neo-cli.exe /noverify`

when you type in `show state`

Run `.\neo-cli.exe /noverify`

when you type in `show state`