Native: store ID->hash mapping for native contracts too#2833
Merged
shargon merged 2 commits intoneo-project:masterfrom Jan 7, 2023
Merged
Native: store ID->hash mapping for native contracts too#2833shargon merged 2 commits intoneo-project:masterfrom
shargon merged 2 commits intoneo-project:masterfrom
Conversation
This is an omission of neo-project#2807, even though native hashes are well-known GetContractById better be symmetric for all contracts. Related to nspcc-dev/neo-go#2837.
AnnaShaleva
approved these changes
Dec 7, 2022
shargon
approved these changes
Dec 12, 2022
vncoelho
approved these changes
Dec 28, 2022
Member
|
@shargon @erikzhang Merge? |
Closed
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an omission of #2807, even though native hashes are well-known GetContractById better be symmetric for all contracts. Related to nspcc-dev/neo-go#2837.