Skip to content

Fix tokens in nns#2286

Merged
shargon merged 2 commits intoneo-project:masterfrom
bettybao1209:fix-nns
Feb 2, 2021
Merged

Fix tokens in nns#2286
shargon merged 2 commits intoneo-project:masterfrom
bettybao1209:fix-nns

Conversation

@bettybao1209
Copy link
Copy Markdown
Contributor

@bettybao1209 bettybao1209 commented Feb 2, 2021

Methods returned in base class should be non-private.

@erikzhang
Copy link
Copy Markdown
Member

erikzhang commented Feb 2, 2021

Why public?

@bettybao1209
Copy link
Copy Markdown
Contributor Author

bettybao1209 commented Feb 2, 2021 •
edited
Loading

Why public?

https://github.com/neo-project/neo/blob/master/src/neo/SmartContract/Native/NativeContract.cs#L61
For BindingFlags.NonPublic, only protected and internal methods on base classes are returned; private methods on base classes are not returned. Otherwise, we should use GetType().BaseType to find the base type.

@shargon shargon merged commit 6285ee1 into neo-project:master Feb 2, 2021
@bettybao1209 bettybao1209 deleted the fix-nns branch February 2, 2021 08:54
ixje added a commit to CityOfZion/neo-mamba that referenced this pull request Feb 26, 2021
@ixje
https://github.com/neo-project/neo/pull/2286
bdc90c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shargon shargon shargon approved these changes

@erikzhang erikzhang erikzhang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bettybao1209 @erikzhang @shargon