Merged
Conversation
vncoelho
previously approved these changes
Jan 28, 2021
Member
|
I think maybe 0 should be the first. |
Member
|
I think that 1 sounds good because native starts with -1. |
Member
|
But either are good to me. |
Member
Author
|
As @vncoelho said, we have <0 for native >0 for non native, 0 could be a default value to know that it's not stored. |
This reverts commit 8a2ec53.
erikzhang
approved these changes
Jan 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now the fist Id it's 0, it should be 1