Skip to content

Reserve 4 bytes for NefFile#2160

Closed
erikzhang wants to merge 5 commits intomasterfrom
neffile-reserve
Closed

Reserve 4 bytes for NefFile#2160
erikzhang wants to merge 5 commits intomasterfrom
neffile-reserve

Conversation

@erikzhang
Copy link
Copy Markdown
Member

No description provided.

@shargon
Copy link
Copy Markdown
Member

shargon commented Dec 17, 2020

Maybe we can reserve more, 16 or 32

@erikzhang
Copy link
Copy Markdown
Member Author

Maybe we can reserve more, 16 or 32

I think 4 bytes are enough. Because each byte can be extended to a varint.

@shargon
Copy link
Copy Markdown
Member

shargon commented Dec 17, 2020

I will update dev-pack after merge it

@superboyiii superboyiii mentioned this pull request Dec 21, 2020
36 tasks
@shargon
Copy link
Copy Markdown
Member

shargon commented Dec 21, 2020

If we will add a methods table, is not better to add this table instead of this reserved bytes (or both)?

@erikzhang
Copy link
Copy Markdown
Member Author

Replaced by #2185

@erikzhang erikzhang closed this Dec 28, 2020
@erikzhang erikzhang deleted the neffile-reserve branch December 28, 2020 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants