Skip to content

Fix Native Contracts serialization#1983

Closed
shargon wants to merge 8 commits intoneo-project:masterfrom
shargon:fix-native-serialization
Closed

Fix Native Contracts serialization#1983
shargon wants to merge 8 commits intoneo-project:masterfrom
shargon:fix-native-serialization

Conversation

@shargon
Copy link
Copy Markdown
Member

@shargon shargon commented Oct 1, 2020

Related to #1978

  • Changed from GetInteroperable to GetSerializableList when the interoperable object it's a list.
  • It's possible to create a Denial of Service if we store more than 16 entries.

* Fix Witness max size

* Fix comment

* Fix comment

* Change it to use constants

* Changed to 1024

* Fix UT
@erikzhang
Copy link
Copy Markdown
Member

It should be an IInteroperable. Otherwise it is impossible to read it from another contract. We should limit the count before writing.

@shargon
Copy link
Copy Markdown
Member Author

shargon commented Oct 4, 2020

Ok, I will close it and open a new one

@shargon shargon closed this Oct 4, 2020
@shargon shargon deleted the fix-native-serialization branch October 4, 2020 09:57
@shargon shargon mentioned this pull request Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants