Include verification offset inside ScriptHash#1961
Include verification offset inside ScriptHash#1961shargon wants to merge 4 commits intoneo-project:masterfrom
Conversation
|
I will fix the UT after the review |
|
But why this or #1964? What's wrong with |
|
We can extend NefFile to include the manifest, and then use the hash of the NefFile as the deployed contract hash. |
|
Do you want a different hash for the same script? |
|
We can set the hash of the smart contract acording to the id |
|
If the ABI changes, the function of the contract changes too. And you can get a different hash of a script by adding a |
|
and what happens if the user update the manifest only, it should migrate the hash? |
He must upload a new nef file. |
|
ok, I will create a new pr according to this |
|
We can create multiple PRs. The first is to modifying NefFile to include the manifest and remove the script hash. |
|
Closed because there are a better solutions |
No description provided.