Skip to content

[neox] consensus#1702

Closed
ZhangTao1596 wants to merge 56 commits intoneo-project:masterfrom
ZhangTao1596:neox-consensus
Closed

[neox] consensus#1702
ZhangTao1596 wants to merge 56 commits intoneo-project:masterfrom
ZhangTao1596:neox-consensus

Conversation

@ZhangTao1596
Copy link
Copy Markdown

@ZhangTao1596 ZhangTao1596 commented Jun 15, 2020

mpt integration (Step 1/4)

Process state root in consensus.

  • Add StateRootSignature when send PrepareRequest
  • Check StateRootSignature proposaled in PrepareRequest received.
  • Relay StateRoot when commit.

@erikzhang @shargon @Tommo-L Can you please have a look?

@ZhangTao1596
Copy link
Copy Markdown
Author

We have another option is add state root signature in PreparationPayloads and relay StateRoot when commit.

In testnet, We find that if only one cn collected all commits and relay block but doesn't relay state root, the whole network will lose state root.

Copy link
Copy Markdown
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KickSeason could you change the base branch to a new one, and later, merge all together?

@ZhangTao1596
Copy link
Copy Markdown
Author

@erikzhang @shargon Can you please have a look.

@ZhangTao1596 ZhangTao1596 changed the title [neox] Neox consensus [neox] consensus Jun 22, 2020
@shargon
Copy link
Copy Markdown
Member

shargon commented Jun 22, 2020

@ZhangTao1596
Copy link
Copy Markdown
Author

Close this to merge to neox branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants