Cache nonexsistent key in datacache#1599
Cache nonexsistent key in datacache#1599Qiao-Jin wants to merge 10 commits intoneo-project:masterfrom
Conversation
| } | ||
|
|
||
| private readonly Dictionary<TKey, Trackable> dictionary = new Dictionary<TKey, Trackable>(); | ||
| private readonly HashSet<TKey> nonexistentKeySet = new HashSet<TKey>(); |
There was a problem hiding this comment.
It should have a maximum number of entries.
There was a problem hiding this comment.
Yes I also think so. I think we should have maximum number of entries both for this hashset and dictionary above.
There was a problem hiding this comment.
nonexistentKeySet is a bloom filter.
There was a problem hiding this comment.
Yes, it could be a bloom filter.
There was a problem hiding this comment.
But there is a bloom filter in leveldb, why do we need another?
There was a problem hiding this comment.
We'll test the leveldb bloom filter.
There was a problem hiding this comment.
After testing it seems situation is much better after a 20-bit bloom filter added to levelDB startup. But still it will take somehow longer time for persisting than this commit, maybe due to more calling stacks
|
Replaced by neo-project/neo-modules#253 |
|
Test Env: Test Condition: Transaction send speed: 2000 tx/s send neo/gas
|
|
This can be closed? |
|
Closed due to Add BloomFilter to levelDB |
Close #1600