Closed
Conversation
added 2 commits
January 10, 2020 16:17
vncoelho
previously approved these changes
Jan 10, 2020
Re-thinking if we should merge this PR on @john-h-k
Member
|
@Tommo-L, perhaps we could merge this PR on #1387, since @john-h-k and @MithrilMan started the topic. |
shargon
reviewed
Jan 10, 2020
| Span<byte> dst = new Span<byte>(p, Length); | ||
| value[..Length].CopyTo(dst); | ||
| } | ||
| Span<byte> dst = MemoryMarshal.AsBytes(MemoryMarshal.CreateSpan(ref value1, Length / sizeof(ulong))); |
Member
There was a problem hiding this comment.
Why not use the same schema as Uint160?
Contributor
Author
Contributor
Author
@shargon Uint160 has two different types(ulong and uint) |
Member
|
Merged @Tommo-L, I cloned his repo and added yours as upstream. Then, I checked into his branch |
Contributor
Author
|
Thank you 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relate to #1387