Contract Guid by counter#1405
Merged
erikzhang merged 24 commits intoneo-project:contract-guidfrom Jan 17, 2020
doubiliu:contract-guid-Fix
Merged
Contract Guid by counter#1405erikzhang merged 24 commits intoneo-project:contract-guidfrom doubiliu:contract-guid-Fix
erikzhang merged 24 commits intoneo-project:contract-guidfrom
doubiliu:contract-guid-Fix
Conversation
shargon
reviewed
Jan 10, 2020
eryeer
reviewed
Jan 10, 2020
eryeer
reviewed
Jan 10, 2020
eryeer
reviewed
Jan 10, 2020
Tommo-L
reviewed
Jan 11, 2020
Member
|
It's ready to review? |
eryeer
reviewed
Jan 14, 2020
eryeer
reviewed
Jan 14, 2020
erikzhang
reviewed
Jan 14, 2020
Co-Authored-By: Erik Zhang <erik@neo.org>
Co-Authored-By: Erik Zhang <erik@neo.org>
Co-Authored-By: Erik Zhang <erik@neo.org>
Co-Authored-By: Erik Zhang <erik@neo.org>
Co-Authored-By: Erik Zhang <erik@neo.org>
vncoelho
approved these changes
Jan 14, 2020
Member
vncoelho
left a comment
There was a problem hiding this comment.
I think that we can merge this one for moving forward and improve the other opened PR.
shargon
approved these changes
Jan 15, 2020
erikzhang
previously requested changes
Jan 15, 2020
Co-Authored-By: Erik Zhang <erik@neo.org>
shargon
approved these changes
Jan 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use global counters to implement Guid.