-
Notifications
You must be signed in to change notification settings - Fork 1k
Send "notfound" message when inventory is not found. #1132
Copy link
Copy link
Closed
Labels
DiscussionInitial issue state - proposed but not yet acceptedInitial issue state - proposed but not yet acceptedEnhancementType - Changes that may affect performance, usability or add new features to existing modules.Type - Changes that may affect performance, usability or add new features to existing modules.P2PModule - peer-to-peer message exchange and network optimisations, at TCP or UDP level (not HTTP).Module - peer-to-peer message exchange and network optimisations, at TCP or UDP level (not HTTP).
Milestone
Description
Metadata
Metadata
Assignees
Labels
DiscussionInitial issue state - proposed but not yet acceptedInitial issue state - proposed but not yet acceptedEnhancementType - Changes that may affect performance, usability or add new features to existing modules.Type - Changes that may affect performance, usability or add new features to existing modules.P2PModule - peer-to-peer message exchange and network optimisations, at TCP or UDP level (not HTTP).Module - peer-to-peer message exchange and network optimisations, at TCP or UDP level (not HTTP).
(Originally from @decentralisedkev on #366)
Summary
When nodeA asks nodeB for a header, if nodeB does not have the header, he will not tell nodeA. nodeA will wait for nodeB until some set of time, which slows down nodeA.
Note: I know we have 'notfound' message but I can't affirm this is being used for that. If this is already implemented this way, we should close this issue.
Do you have any solution you want to propose?
Once nodeB cannot find the header, he should send back a notfound message with the hashes of the inv that he could not find, along with a separate message of the headers that he could find.
Where in the software does this update applies to?
@shargon could you confirm if this already exists?