Skip to content

Converted to dotnet standard 2.1#6

Merged
shargon merged 8 commits intoneo-project:masterfrom
cschuchardt88:standard-try
Jan 9, 2024
Merged

Converted to dotnet standard 2.1#6
shargon merged 8 commits intoneo-project:masterfrom
cschuchardt88:standard-try

Conversation

@cschuchardt88
Copy link
Copy Markdown
Member

@cschuchardt88 cschuchardt88 commented Dec 31, 2023

Comment thread src/Neo.Cryptography.BLS12_381/Neo.Cryptography.BLS12_381.csproj
Jim8y
Jim8y previously approved these changes Dec 31, 2023
@cschuchardt88
Copy link
Copy Markdown
Member Author

@Jim8y
should we change the version number? If so to what? 0.3.0? or 1.0.0?

@Jim8y
Copy link
Copy Markdown

Jim8y commented Dec 31, 2023

Let's use 0.0.3, let erik to decide when to use 1.0.0

Comment thread src/Neo.Cryptography.BLS12_381/Bls12.Adder.cs Outdated
@cschuchardt88 cschuchardt88 requested a review from shargon January 2, 2024 03:49
Jim8y
Jim8y previously approved these changes Jan 4, 2024
@Jim8y
Copy link
Copy Markdown

Jim8y commented Jan 4, 2024

@shargon

@shargon
Copy link
Copy Markdown
Member

shargon commented Jan 4, 2024

I think that we should use compiler directives, seems that there are a lot of reflection, it will be slower and harder to maintain.

@cschuchardt88
Copy link
Copy Markdown
Member Author

@shargon this is the easiest way of doing it, without rewriting a lot of code. Reflection is fast now a days. Just think about all System Attributes in asp.net core and other libraries. They all use reflection for getting attributes

@shargon
Copy link
Copy Markdown
Member

shargon commented Jan 4, 2024

@shargon this is the easiest way of doing it, without rewriting a lot of code. Reflection is fast now a days. Just think about all System Attributes in asp.net core and other libraries. They all use reflection for getting attributes

Maybe we should wait for .net standard 3, why we need it right now?

@cschuchardt88
Copy link
Copy Markdown
Member Author

cschuchardt88 commented Jan 4, 2024

neo-project/neo#3044 (comment)

netstandard2.1 is the last version ever; says microsoft.

@shargon
Copy link
Copy Markdown
Member

shargon commented Jan 4, 2024

netstandard2.1 is the last version ever; says microsoft.

Then this seems like it will not be maintained.

@cschuchardt88
Copy link
Copy Markdown
Member Author

cschuchardt88 commented Jan 4, 2024

You have to understand what netstandard is

.NET Standard allows libraries to build against the agreed
on set of common APIs, ensuring they can be used in any 
.NET application—mobile, desktop, IoT, web, or anywhere you write .NET code.

https://dotnet.microsoft.com/en-us/platform/dotnet-standard#:~:text=NET%20implementations.-,.,NET%20code.

So they would wait for the OS to have some common APIs before they update dotnet standard. But there will still be support and bug fixes

@cschuchardt88
Copy link
Copy Markdown
Member Author

cschuchardt88 commented Jan 4, 2024

My goal in the future is to get neo-core to convert, and have the blockchain run on a phone. Like a lite node. Plus help with developers want to run core or vm on phones or other platforms.

@gsmachado
Copy link
Copy Markdown

My goal in the future is to get neo-core to convert, and have the blockchain run on a phone. Like a lite node. Plus help with developers want to run core or vm on phones or other platforms.

☝️ this would be AWESOME. ❤️

@shargon
Copy link
Copy Markdown
Member

shargon commented Jan 9, 2024

@cschuchardt88 please, could you update the PR?

@cschuchardt88
Copy link
Copy Markdown
Member Author

@shargon all done

@coveralls
Copy link
Copy Markdown

coveralls commented Jan 9, 2024

Pull Request Test Coverage Report for Build 7463345327

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 81.114%

Totals Coverage Status
Change from base Build 7457521814: 0.1%
Covered Lines: 2059
Relevant Lines: 2474

💛 - Coveralls

@cschuchardt88
Copy link
Copy Markdown
Member Author

cschuchardt88 commented Jan 9, 2024

Nvm

@shargon shargon merged commit 58e4e45 into neo-project:master Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants