cms: remove the use of KeyWrap, use Kek directly#4
Merged
nemynm merged 2 commits intonemynm:keywrap-traitfrom Nov 17, 2024
Merged
cms: remove the use of KeyWrap, use Kek directly#4nemynm merged 2 commits intonemynm:keywrap-traitfrom
nemynm merged 2 commits intonemynm:keywrap-traitfrom
Conversation
Author
|
the merge is required because of the const-oid version requirement that RustCrypto/key-wraps#39 brings. |
Owner
|
I think key-wraps crate got some re-factoring that changed its API yesterday, should I just recreate a clean feature branch? |
Author
|
yeah that moved yesterday morning. I'll update that branch. |
58bc8ef to
fb63743
Compare
Owner
|
Should we update for latest aes-kw changes here or merge and do it after? |
Author
|
We can do that here, but it'd be nice if you could rebase the keywrap-trait branch |
Owner
sure I'll do it, favor "rebase" rebase or "merge" rebase? |
Author
|
I meant rebase rebase |
eee4c5a to
2828b7e
Compare
Owner
|
Rebase it is! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings a merge of
origin/masterbecauseconst-oidgot bumped, ideally the whole branch needs a rebase.Only the last commit is required here.