fix: matrix expansion logic#5294
Merged
mergify[bot] merged 2 commits intonektos:masterfrom Aug 21, 2025
Merged
Conversation
* add another test * remove //nolint:gocyclo
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5294 +/- ##
==========================================
+ Coverage 74.65% 74.84% +0.18%
==========================================
Files 73 73
Lines 11139 11198 +59
==========================================
+ Hits 8316 8381 +65
+ Misses 2186 2181 -5
+ Partials 637 636 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
The new test case of #2649 can be pulled after this changed and it succeeds. |
Contributor
Author
|
Summary, I forget to remove old code that messed up my newer code. Most likely due to an invalid test case that is changed in both this and linked older PR. |
panekj
approved these changes
Aug 21, 2025
D0CT4
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add another test
remove //nolint:gocyclo
TODO check if the test in https://github.com/nektos/act/blob/162671cb083609e531939db62cf6b176d6d5a376/pkg/model/workflow_test.go could be merged here