Skip to content

feat: --validate and --strict#2717

Merged
mergify[bot] merged 6 commits intomasterfrom
christopherhx/validate-strict
Jun 11, 2025
Merged

feat: --validate and --strict#2717
mergify[bot] merged 6 commits intomasterfrom
christopherhx/validate-strict

Conversation

@ChristopherHX
Copy link
Contributor

@ChristopherHX ChristopherHX commented Mar 28, 2025

Use act --validate --strict to test for errors of the strict schema without running anything.

Could report a small number of phantom problems, but this opt in variant should not make people defer updates.

Closes #2716

@mergify mergify bot added the needs-work Extra attention is needed label Mar 28, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2025 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 9 0 0.04s
✅ REPOSITORY gitleaks yes no 2.71s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 11.44s
✅ REPOSITORY secretlint yes no 1.21s
✅ REPOSITORY trivy-sbom yes no 0.39s
✅ REPOSITORY trufflehog yes no 3.97s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@pull-request-size pull-request-size bot added size/L and removed size/M labels Mar 28, 2025
@codecov
Copy link

codecov bot commented Mar 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 76.92308% with 6 lines in your changes missing coverage. Please review.

Project coverage is 74.76%. Comparing base (bd4bc99) to head (5462ae9).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
cmd/root.go 50.00% 2 Missing and 1 partial ⚠️
pkg/model/workflow.go 87.50% 2 Missing ⚠️
pkg/model/planner.go 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2717      +/-   ##
==========================================
+ Coverage   74.65%   74.76%   +0.10%     
==========================================
  Files          73       73              
  Lines       11139    11185      +46     
==========================================
+ Hits         8316     8362      +46     
- Misses       2186     2187       +1     
+ Partials      637      636       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify mergify bot removed the needs-work Extra attention is needed label Mar 28, 2025
cplee
cplee previously approved these changes Mar 29, 2025
View reviewed changes
@mergify mergify bot added the conflict PR has conflicts label Mar 29, 2025
@mergify mergify bot removed the conflict PR has conflicts label Mar 29, 2025
@panekj
Copy link
Contributor

panekj commented Jun 11, 2025

Mind resolving the conflict?

panekj
panekj previously approved these changes Jun 11, 2025
View reviewed changes
@mergify mergify bot added the conflict PR has conflicts label Jun 11, 2025
@mergify mergify bot removed the conflict PR has conflicts label Jun 11, 2025
@ChristopherHX
Copy link
Contributor Author

ChristopherHX commented Jun 11, 2025 •
edited
Loading

I almost forgot this change still exists in nektos/act...

resolving the conflict

The last time I did this, it was not worth the effort. e.g. Approval is gone by conflict resolution regardless how trivial it is 😅

@panekj
Copy link
Contributor

panekj commented Jun 11, 2025

Approval is gone by conflict resolution regardless how trivial it is 😅

I know, just wanted to signal that I like the feature :>

@mergify mergify bot merged commit 4ba1c2b into master Jun 11, 2025
12 checks passed
@mergify mergify bot deleted the christopherhx/validate-strict branch June 11, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panekj panekj panekj approved these changes

@cplee cplee cplee left review comments

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Is it possible to validate workflows with act, without running them?

3 participants

@ChristopherHX @panekj @cplee