Add tests against reading config files#2682
Merged
mergify[bot] merged 6 commits intonektos:masterfrom Feb 25, 2025
Merged
Conversation
Contributor
ChristopherHX
left a comment
There was a problem hiding this comment.
Thank you, more cmd tests are good. I left an optional enhancement.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2682 +/- ##
===========================================
+ Coverage 61.56% 74.40% +12.84%
===========================================
Files 53 72 +19
Lines 9002 11051 +2049
===========================================
+ Hits 5542 8223 +2681
+ Misses 3020 2192 -828
- Partials 440 636 +196 ☔ View full report in Codecov by Sentry. |
ChristopherHX
approved these changes
Feb 23, 2025
cplee
approved these changes
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My sinister scheme here is to get #2681 resolved in the end, but this PR is an enhancement regardless of that I guess.