Skip to content

feat: [BREAKING] make use of the new action cache#2509

Closed
ChristopherHX wants to merge 13 commits intomasterfrom
2472-make-use-new-action-cache-the-new-default-for-downloading-actions
Closed

feat: [BREAKING] make use of the new action cache#2509
ChristopherHX wants to merge 13 commits intomasterfrom
2472-make-use-new-action-cache-the-new-default-for-downloading-actions

Conversation

@ChristopherHX
Copy link
Contributor

@ChristopherHX ChristopherHX commented Oct 29, 2024 •
edited
Loading

Breaking

  • removal of old backend
  • removal of cli flag
  • migrated tests
  • frees up storage of old backend

Fixes

  • remote docker actions corrected to pass tests

Tracked in #2472

@ChristopherHX
feat: make use of the new action cache
9b8af8f 
* removal of old backend
* migrated tests
@ChristopherHX ChristopherHX linked an issue Oct 29, 2024 that may be closed by this pull request
Make --use-new-action-cache the new default for downloading actions #2472
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 11 0 0.06s
✅ REPOSITORY gitleaks yes no 2.37s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 9.22s
✅ REPOSITORY secretlint yes no 1.09s
✅ REPOSITORY trivy-sbom yes no 0.11s
✅ REPOSITORY trufflehog yes no 3.32s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@pull-request-size pull-request-size bot added size/L and removed size/XL labels Nov 2, 2024
@codecov
Copy link

codecov bot commented Nov 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 70.42254% with 21 lines in your changes missing coverage. Please review.

Project coverage is 75.07%. Comparing base (5a80a04) to head (f875732).
Report is 140 commits behind head on master.

Files with missing lines Patch % Lines
pkg/runner/step_action_remote.go 68.75% 7 Missing and 3 partials ⚠️
pkg/runner/action.go 60.00% 7 Missing and 1 partial ⚠️
pkg/container/host_environment.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #2509       +/-   ##
===========================================
+ Coverage   61.56%   75.07%   +13.50%     
===========================================
  Files          53       62        +9     
  Lines        9002     9984      +982     
===========================================
+ Hits         5542     7495     +1953     
+ Misses       3020     1912     -1108     
- Partials      440      577      +137

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChristopherHX
Copy link
Contributor Author

ChristopherHX commented Nov 2, 2024

TLDR I break everything

I consider backporting the code fixes of the new-action-cache before implementing cleanup of old cache

@ChristopherHX ChristopherHX mentioned this pull request Nov 2, 2024
Merged
@ChristopherHX ChristopherHX marked this pull request as ready for review November 3, 2024 00:22
@ChristopherHX ChristopherHX requested a review from a team as a code owner November 3, 2024 00:22
@ChristopherHX
Copy link
Contributor Author

ChristopherHX commented Nov 3, 2024

Backport of code fixes doesn't fulfill coverage, but this one does.

@ChristopherHX ChristopherHX changed the title feat: make use of the new action cache feat: [BREAKING] make use of the new action cache Nov 4, 2024
@ChristopherHX ChristopherHX mentioned this pull request Nov 23, 2024
Closed
@ChristopherHX
Copy link
Contributor Author

ChristopherHX commented Dec 29, 2024

Merge impossible, due to lack of interest.

@ChristopherHX ChristopherHX mentioned this pull request Feb 4, 2025
Open
@ChristopherHX ChristopherHX mentioned this pull request Feb 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size/L stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make --use-new-action-cache the new default for downloading actions

1 participant

@ChristopherHX